Re: CIFS find_tcp_session/GlobalSMBSessionList protection

From: Steven French (
Date: Wed Oct 16 2002 - 16:47:08 EST

So far your fixes have tested out ok. I have made minor additions - e.g.
to move a similar null pointer check (on the private area of the sb)
earlier in umount as well. On the protection of the GlobalSMBSession and
TreeConnection lists, I changed it in my testing to a rwlock_t rather than
a rw_sem since I think we can ensure that it never need be held across any
blocking calls. I will package these in a bitkeeper change set later this
evening and submit them. I have not added in your change to
ipv4_reconnect yet since there are other areas where that particular code
path needs work and I would like to submit the improvements for
reconnection after network failure in one piece.

Thanks for spotting these.

The CIFS VFS seems to be doing ok on the file API stress testing I have
tried so far, but these should help as I do more testing on MP hardware.

Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:30 EST