Re: [PATCH 1/3] Add extended attributes to ext2/3

From: Theodore Ts'o (
Date: Wed Oct 16 2002 - 11:04:08 EST

On Tue, Oct 15, 2002 at 05:00:12PM -0700, Andrew Morton wrote:
> This should be converted to use sector_t for >2TB support, and tested
> with CONFIG_LBD=y and n.

It's only used to store an ext2/3 block number (not a 512 byte sector
number, but a 1k, 2k, or 4k fs block number).

Changing it to be sector_t wouldn't hurt, but it would be less
efficient if CONFIG_LBD were turned on, since ext2/3 would only store
32 bit values into it. If someone needed it for the future, the
change could take place then. It's a simple change: change the type
of e_block, in mbcache.h, and the type of "block" in the function
parameters of mb_cache_entry_insert and mb_cache_entry_get, and you're
done. No change would be needed in the ext3 code.

> The use of a dev_t search key is a bit old-fashioned. Maybe
> use the address of inode->i_sb->s_bdev?

Sure, that would be easy enough to do. In the next patch....

                                                - Ted
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:28 EST