Re: [PATCH 1/4] Add extended attributes to ext2/3

From: Andreas Dilger (adilger@clusterfs.com)
Date: Tue Oct 15 2002 - 00:31:18 EST


On Oct 14, 2002 21:46 -0700, Andrew Morton wrote:
> btw, gcc-2.91.66 is saying:
>
> fs/ext2/xattr.c: In function `ext2_xattr_set':
> fs/ext2/xattr.c:612: warning: `block' might be used uninitialized in this function
>
> But the code is:
>
> int block = EXT2_I(inode)->i_file_acl;
>
> which is rather bizarre. Never seen it do that before.

There's a "goto bad_block" in that function, and it enters _after_
block is set (block is a local variable), so it is impossible for
it to have a valid value.

Cheers, Andreas

--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:53 EST