Re: [PATCH] 2.5.42: build nfsd as module broken

From: Neil Brown (neilb@cse.unsw.edu.au)
Date: Sat Oct 12 2002 - 18:51:32 EST


On Saturday October 12, viro@math.psu.edu wrote:
>
>
> On Sat, 12 Oct 2002, Olaf Dietsche wrote:
>
> > +EXPORT_SYMBOL(cache_fresh);
> > +EXPORT_SYMBOL(cache_flush);
> > +EXPORT_SYMBOL(cache_unregister);
> > +EXPORT_SYMBOL(cache_check);
> > +EXPORT_SYMBOL(cache_clean);
> > +EXPORT_SYMBOL(cache_register);
> > +EXPORT_SYMBOL(cache_init);
> > +EXPORT_SYMBOL(add_word);
> > +EXPORT_SYMBOL(add_hex);
> > +EXPORT_SYMBOL(get_word);
>
> Ahem. Non-static objects called add_word and get_word? Even the cache_...()
> stuff is a namespace pollution (which kind of cache?), but that...

Fair comment.

The words are actually 'quoted words', so maybe:

 qword_add
 qword_addhex
 qword_parse (or qword_get)

 would be better.

The caches are for caching user-space-sourced information (IP ->
hostname, export options, uid->username etc) so maybe

  ucache_*
though that is a bit bland....

  uss_cache_*

(for the trekkies)???

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:44 EST