Re: [BUG] pl2303 oops in 2.4.20-pre10 (and 2.5 too)

From: Barry K. Nathan (barryn@pobox.com)
Date: Sat Oct 12 2002 - 15:56:04 EST


The following patch (which reverts part of 2.4.20-pre2) seems to fix my
pl2303 oopsing (and let me use the device properly again) in 2.4.20-pre2
through -pre5. This patch doesn't work with -pre6 or up though (due to
white space differences and, more importantly, the removal of all 6
variables referenced in the if-statement).

Anyway, I'm posting this in case it provides another clue as to what's
not working.

-Barry K. Nathan <barryn@pobox.com>

--- linux-2.4.20-pre2/drivers/usb/serial/usbserial.c 2002-10-12 00:09:35.000000000 -0700
+++ linux-2.4.20-pre1/drivers/usb/serial/usbserial.c 2002-01-22 13:22:58.000000000 -0800
@@ -1161,6 +1161,15 @@
         /* END HORRIBLE HACK FOR PL2303 */
 #endif
         
+ /* verify that we found all of the endpoints that we need */
+ if (!((interrupt_pipe & type->needs_interrupt_in) &&
+ (bulk_in_pipe & type->needs_bulk_in) &&
+ (bulk_out_pipe & type->needs_bulk_out))) {
+ /* nope, they don't match what we expected */
+ info("descriptors matched, but endpoints did not");
+ return NULL;
+ }
+
         /* found all that we need */
         info("%s converter detected", type->name);
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:44 EST