drivers/block/rd.c compile error

From: Paul Mackerras (paulus@samba.org)
Date: Thu Oct 10 2002 - 01:20:16 EST


This change went into drivers/block/rd.c in 2.5 recently:

diff -urN old/drivers/block/rd.c linux-2.5/drivers/block/rd.c
--- old/drivers/block/rd.c 2002-10-10 16:12:54.000000000 +1000
+++ linux-2.5/drivers/block/rd.c 2002-10-10 08:46:28.000000000 +1000
@@ -213,7 +213,7 @@
                 kunmap(vec->bv_page);
 
                 if (rw == READ) {
- flush_dcache_page(page);
+ flush_dcache_page(sbh->b_page);
                 } else {
                         SetPageDirty(page);
                 }

The trouble with that is that there is no variable called sbh defined
in this function, rd_blkdev_pagecache_IO. Thus we get a compile error
on PPC. The problem wouldn't show up on x86 since flush_dcache_page
is a no-op (i.e. do { } while (0)) there.

What was the change trying to achieve? What was wrong with
flush_dcache_page(page)?

Thanks,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:36 EST