Re: [PATCH] O_STREAMING - flag for optimal streaming I/O

From: Andreas Dilger (adilger@clusterfs.com)
Date: Wed Oct 09 2002 - 10:27:31 EST


On Oct 09, 2002 10:14 -0400, Robert Love wrote:
> On Wed, 2002-10-09 at 10:10, Marco Colombo wrote:
>
> > > #define O_NOFOLLOW 0400000 /* don't follow links */
> > > #define O_NOFOLLOW 0x20000 /* don't follow links */
> > ...
> > 04000000 != 0x400000
> >
> > or am I missing something?
>
> No need. See for example O_NOFOLLOW right above. Each architecture can
> do has it pleases (I wish otherwise, but...).
>
> > (do different archs dream of different O_STREAMING values?)
>
> If they so choose. Just look at the formats of the two numbers you
> posted, even those are different.

I would say - if you are picking a new flag that doesn't need to have
compatibility with any platform-specific existing flag, simply set them
all high enough so that they are the same on all platforms. Just
because some of the flags are broken is no need to make all of them so.

Cheers, Andreas

--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:31 EST