Re: [Ext2-devel] [RFC] [PATCH 3/4] Add extended attributes to ext2/3

From: Theodore Ts'o (
Date: Tue Oct 08 2002 - 17:21:40 EST

On Tue, Oct 08, 2002 at 07:53:22PM +0100, Christoph Hellwig wrote:
> Also please get rid of the registration API for xattr handlers - this
> is inside a single module so hardconding them in the inode operations
> won't hurt. the additional lock for the registration OTOH may hurt and
> it looks really overengineered.

The registration API is also used for the ACL routines. That's why
it's there.

That being said, I'm not at all convinced that allowing things like
the EA routines and the ACL routines to be separate modules is a good
idea. Life would be much simpler if everything was compiled into a
single ext3 subsystem, and we eliminate all of the extra overhead of
having separate modules for specific filesystem features. Certainly
the XFS and JFS folks didn't go down this path.

(That's why I took out to the questions in; I really felt
that it was wrong. I however didn't want to go as far as to remove
the #ifdef's and removing the registration API's without at least
having some discussion on the topic.)

                                                - Ted
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:28 EST