Re: [Ext2-devel] [RFC] [PATCH 2/4] Add extended attributes to ext2/3

From: Theodore Ts'o (
Date: Tue Oct 08 2002 - 13:45:34 EST

On Tue, Oct 08, 2002 at 07:23:06PM +0100, Christoph Hellwig wrote:
> The code doesn't really make ?ny sense outside ext2/ext3. I'd suggest you
> move it there instead of bloating every kernel with it unconditionally.

The code is general enough that it can be used for a variety of
purposes, not just ext2/ext3, although granted at the moment only ext2
and ext3 are using it. Also, having two copies of the code bewteen
the ext2 and ext3 directories is undeseriable.

Probably the right thing to do is to add the appropriate logic in
fs/ so it's only enabled when necessary.

> __mb_cache_entry_in_lru() is buggy and can't work anymore now that akpm removed
> some list_head debugging.

Oops. Nice catche. I didn't notice since it's only used in the
mb_assert code, which I hadn't enabled.

> And please get rid of the LINUX_VERSION_CODE checks..

Thanks. Missed those....

                                        - Ted
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:26 EST