Re: [Evms-devel] Re: [PATCH] EVMS core 3/4: evms_ioctl.h

From: Alexander Viro (viro@math.psu.edu)
Date: Mon Oct 07 2002 - 12:50:00 EST


On Mon, 7 Oct 2002, Christoph Hellwig wrote:

> I don't think that basing kernel internal interfaces on ioctl is
> a smart idea. Just add another function pionter to your operations
> vector for every operation you want supported on volumes.

s/every/& generic/. Other than that, seconded. BTW, one of the pending
changes is taking the last more or less generic ioctl (HDIO_GETGEO) into
a separate method...

->ioctl() is for driver-specific crud; stuff that won't be used by
any generic application. "Make a cuckoo jump out of drive and sing
'1000 bottles of beer'" is a valid ioctl. "Get drive size" isn't.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:59 EST