Re: PATCH: 2.5.40 sane minimum proc count

From: Matthew Wilcox (willy@debian.org)
Date: Mon Oct 07 2002 - 08:27:00 EST

Next message: Adam J. Richter: "linux-2.5.40 64GB highmem BUG()"
Previous message: Pavel Machek: "lm-sensors for 2.5.40?"
Maybe in reply to: Alan Cox: "PATCH: 2.5.40 sane minimum proc count"
Next in thread: Alan Cox: "Re: PATCH: 2.5.40 sane minimum proc count"
Reply: Alan Cox: "Re: PATCH: 2.5.40 sane minimum proc count"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

max_threads = mempages / (THREAD_SIZE/PAGE_SIZE) / 8;

- init_task.rlim[RLIMIT_NPROC].rlim_cur = max_threads/2;
- init_task.rlim[RLIMIT_NPROC].rlim_max = max_threads/2;
+ /*
+ * we need to allow at least 10 threads to boot a system
+ */
+ init_task.rlim[RLIMIT_NPROC].rlim_cur = max(10, max_threads/2);
+ init_task.rlim[RLIMIT_NPROC].rlim_max = max(10, max_threads/2);

why not simply:

max_threads = mempages / (THREAD_SIZE/PAGE_SIZE) / 8;

+ /* we need to allow at least 20 threads to boot a system */
+ if (max_threads < 20)
+ max_threads = 20;
+
init_task.rlim[RLIMIT_NPROC].rlim_cur = max_threads/2;
init_task.rlim[RLIMIT_NPROC].rlim_max = max_threads/2;

i think we're going to see more kernel threads with 2.5 than we did with 2.4;
let's be safer.

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Adam J. Richter: "linux-2.5.40 64GB highmem BUG()"
Previous message: Pavel Machek: "lm-sensors for 2.5.40?"
Maybe in reply to: Alan Cox: "PATCH: 2.5.40 sane minimum proc count"
Next in thread: Alan Cox: "Re: PATCH: 2.5.40 sane minimum proc count"
Reply: Alan Cox: "Re: PATCH: 2.5.40 sane minimum proc count"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:58 EST