Re: [PATCH] Bluetooth kbuild fix and config cleanup

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sun Oct 06 2002 - 18:47:04 EST


On Sun, 6 Oct 2002, Marcel Holtmann wrote:
>
> diff -Nru a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
> --- a/drivers/bluetooth/Makefile Sun Oct 6 19:19:06 2002
> +++ b/drivers/bluetooth/Makefile Sun Oct 6 19:19:06 2002
> @@ -9,9 +9,14 @@
> obj-$(CONFIG_BLUEZ_HCIBT3C) += bt3c_cs.o
> obj-$(CONFIG_BLUEZ_HCIBLUECARD) += bluecard_cs.o
>
> -hci_uart-y := hci_ldisc.o
> -hci_uart-$(CONFIG_BLUEZ_HCIUART_H4) += hci_h4.o
> -hci_uart-$(CONFIG_BLUEZ_HCIUART_BCSP) += hci_bcsp.o
> -hci_uart-objs := $(hci_uart-y)
> +hci_uart-objs := hci_ldisc.o
> +
> +ifeq ($(CONFIG_BLUEZ_HCIUART_H4),y)
> + hci_uart-objs += hci_h4.o
> +endif
> +
> +ifeq ($(CONFIG_BLUEZ_HCIUART_BCSP),y)
> + hci_uart-objs += hci_bcsp.o
> +endif
>
> include $(TOPDIR)/Rules.make

Hmm.. This seems to be reverting a perfectly good clean Makefile without
any conditionals to the old-stype setup. Please don't do that.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:56 EST