On Fri, 4 Oct 2002, Martin Schwidefsky wrote:
> Hi Linus,
> the 27th patch has joint the patch set for s/390. Minimum set for something
> useful is again the first 7 patches.
>
> The list of patches and some comments:
>
> 07: Fixes and more cleanup for the dasd driver. Thanks to Al Viro we
> got rid of the ugly things in the dasd driver. The only big thing
> left is big minors. In preparation we removed kdev_t where possible.
* please switch to use of alloc_disk()/put_disk()
* don't bother with disk->part allocation - it's done by add_disk()
* ditto for freeing it (del_gendisk())
* dasd_partition_to_kdev_t() - please use ->gdp->{major,first_minor}
* s/bdevname(d_device->bdev)/d_device->gdp->disk_name/
* lose ->bdev
Note that we are getting bdev->bd_disk and disk->private pretty soon, so
we'll have very easy way to do your devmap by bdev stuff.
Anther thing: tapeblock.c and friends.
<rant>
In ~ 2.5.16 blksize_size[] had been removed. Tape-related code
in s390 was using it, but that was fairly easy to get rid of. Now, in
2.5.21 somebody (presumably architecture maintainers) had submitted a
patch that
* reverted all compile fixes, etc. that had happened in 2.5
* reintroduced use of (long-dead) blksize_size[]
^#$^%@!
Folks, if you do something like that, at least check the bloody changelog...
</rant>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:46 EST