Re: [PATCH] 2.5.40 - DMA-mapping && misc

• Next message: Scott Bronson: "Re: FAT/VFAT and the sync flag"
• Previous message: Josh McKinney: "2.5.40-ac3 compile error"
• Maybe in reply to: Carlos E Gorges: "[PATCH] 2.5.40 - DMA-mapping && misc"
• Next in thread: Pete Zaitcev: "Re: [PATCH] 2.5.40 - DMA-mapping && misc"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

- virt_to_bus(((struct scatterlist *)cmd->buffer)[i].address) :
+ virt_to_bus(
+ page_address(((struct scatterlist *)cmd->buffer)[i].page) +
+ ((struct scatterlist *)cmd->buffer)[i].offset ) :
             virt_to_bus(cmd->request_buffer);

have you actually read Documentation/DMA-mapping.txt? It says quite plainly:

Drivers converted fully to this interface should not use virt_to_bus any
longer, nor should they use bus_to_virt.
[...]
It is planned to completely remove virt_to_bus() and bus_to_virt() as
they are entirely deprecated.

So, your patch is quite insufficient.

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Scott Bronson: "Re: FAT/VFAT and the sync flag"
• Previous message: Josh McKinney: "2.5.40-ac3 compile error"
• Maybe in reply to: Carlos E Gorges: "[PATCH] 2.5.40 - DMA-mapping && misc"
• Next in thread: Pete Zaitcev: "Re: [PATCH] 2.5.40 - DMA-mapping && misc"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:46 EST