Re: [PATCH] EVMS core 2/4: evms.h

From: Mark Peloquin (peloquin@us.ibm.com)
Date: Fri Oct 04 2002 - 09:56:11 EST


On 10/04/2002 at 9:03 AM, Kevin Corry wrote:
> > <snip...>
> >
> > > Possibly shortened to:
> > >
> > > static inline int list_member(struct list_head *member)
> > > {
> > > return member->next && member->prev;
> > > }
> > >
> > > Faster, and (at least to me) it looks more obvious.
> >
> > Yes, this may be shorter. However with this change
> > the return type would also need to be changed to
> > portable across archs.

> What would the return type have to be?

Ok, I was (incorrectly) thinking this would return
a *list_head, but after waking up a bit more I see
the "&&" which should return a int.

So I agree Robert's improvement is fine!

Mark

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:44 EST