Re: EVMS Submission for 2.5

From: Greg KH (greg@kroah.com)
Date: Thu Oct 03 2002 - 18:07:28 EST


On Thu, Oct 03, 2002 at 04:56:37PM -0500, Kevin Corry wrote:
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/evms/runtime/linux-2.5/

Heh, looks like you ran the thing through Lindent without looking at the
output. Lindent is a great place to start, but it does generate lines
like the following which you will probably want to fix up by hand
(unless you really want to try to maintain things like this...)

                                                volume_group->
                                                    volume_list[AIXppent->
                                                                lv_index -
                                                                1]->
                                                    le_to_pe_map_mir1
                                                    [le_number].
                                                    pe_sector_offset = offset;

oh, here's another one that's even messier:

                                                        volume_group->
                                                            volume_list
                                                            [AIXppent->
                                                             lv_index -
                                                             1]->
                                                            le_to_pe_map_mir2
                                                            [le_number].
                                                            pe_sector_offset =
                                                            offset;

You also have a number of local variables that use InterCaps.

But, 80 column rants aside, the code looks much better, thank you for
cleaning it up.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:42 EST