> +static mempool_t *my_bio_split_pool, *my_bio_pool;
> +static kmem_cache_t *my_bio_split_slab, *my_bio_pool_slab;
Umm, static variables in header files?
> +
> +/**
> + * slab_pool_alloc
> + * @gfp_mask: GFP allocation flag
> + * @data: mempool prototype required fields
> + *
> + * mempool allocate function
> + **/
> +static void *
> +slab_pool_alloc(int gfp_mask, void *data)
> +{
> + return kmem_cache_alloc(data, gfp_mask);
> +}
> +
> +/**
> + * slab_pool_free
> + * @ptr: mempool prototype required fields
> + * @data: mempool prototype required fields
> + *
> + * mempool free function
> + **/
> +static void
> +slab_pool_free(void *ptr, void *data)
> +{
> + kmem_cache_free(data, ptr);
> +}
I think these two could go to slab.c instead.
> + if (!my_bio_split_slab) {
> + panic("unable to create EVMS Bio Split cache.");
What about graceful error handling?
All in all I think this should rather be a source file, I can't
see anything EVMS-specific either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:39 EST