Re: kernel makefiles broken?

From: Adrian Bunk (bunk@fs.tum.de)
Date: Wed Oct 02 2002 - 07:12:55 EST


On Wed, 2 Oct 2002, Russell King wrote:

> Hi,

Hi Russell,

> I've noticed on two machines now that the kernel makefiles seem to have
> changed their behaviour. One x86 RH-based, and one parisc debian based.
>
> make seems to ignores errors from gcc, and only stops when trying to link.
> On a PARISC box, I've seen the build get all the way though to successfully
> linking vmlinux, even with compilation failures. Obviously not ideal,
> since vmlinux may not reflect reality.
>...

known bug, already fixed in Linus' BK tree, patch is below.

cu
Adrian

--- a/Rules.make Tue Oct 1 21:00:23 2002
+++ b/Rules.make Tue Oct 1 21:00:23 2002
@@ -517,13 +517,6 @@
   include $(cmd_files)
 endif

-# Emacs compile mode works best with relative paths to find files (OK
-# if verbose, as it tracks the make[1] entries and exits, etc.)
-
-ifneq ($(KBUILD_VERBOSE),1)
- filter-output = 2>&1 | sed 's \(^[^/][A-Za-z0-9_./-]*:[ 0-9]\) $(RELDIR)/\1 '
-endif
-
 # function to only execute the passed command if necessary

 if_changed = $(if $(strip $? \
@@ -543,7 +536,7 @@
                           $(filter-out $(cmd_$@),$(cmd_$(1)))),\
         @set -e; \
         $(if $($(quiet)cmd_$(1)),echo ' $($(quiet)cmd_$(1))';) \
- $(cmd_$(1)) $(filter-output); \
+ $(cmd_$(1)); \
         $(TOPDIR)/scripts/fixdep $(depfile) $@ $(TOPDIR) '$(cmd_$(1))' > $(@D)/.$(@F).tmp; \
         rm -f $(depfile); \
         mv -f $(@D)/.$(@F).tmp $(@D)/.$(@F).cmd)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:34 EST