a bug in 8250.c

From: Hu Gang (hugang@soulinfo.com)
Date: Sat Sep 28 2002 - 21:15:23 EST

Hi Russell King:

In serial8250_request_std_resource@825.c, if all is pass it return 0, or failed return -XX, But you use
        ret = serial8250_request_std_resource(up, &res_std);
-> if (ret)
                return;
I'm guess it use as .
-> if (ret == 0)

After change code, 2.5.39 Can found my modem.
Please check, If not proble, Please apply.
--------------
Here is the patch.
--- 8250.c Sat Sep 28 11:15:16 2002
+++ 8250.c~fix Sat Sep 28 22:07:36 2002
@@ -1564,7 +1564,7 @@
 
         if (up->port.type == PORT_RSA) {
                 ret = serial8250_request_rsa_resource(up, &res_rsa);
- if (ret)
+ if (ret == 0)
                         return ret;
         }
 
@@ -1611,11 +1611,11 @@
          * tells us whether we can probe for the type of port.
          */
         ret = serial8250_request_std_resource(up, &res_std);
- if (ret)
+ if (ret == 0)
                 return;
 
         ret = serial8250_request_rsa_resource(up, &res_rsa);
- if (ret)
+ if (ret == 0)
                 probeflags &= ~PROBE_RSA;
 
         if (flags & UART_CONFIG_TYPE) 

-- 
		- Hu Gang
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Sep 30 2002 - 22:00:39 EST