On Wed, 2002-09-11 at 00:14, Jean Tourrilhes wrote:
> > This adds the use of TIOCM_MODEM_BITS to irtty.c but not the corresponding
> > addition of it to asm-i386/termios.h:
>
> I would personally would have veto'ed that change, because it
> will work only on i386 (and PA-Risc), whereas the IrDA stack is
> routinely used on ARM and PPC and also work on Alpha.
The change got it by accident
> I would personally perfer the header to define a "default"
> value, and only the broken architecture would need to override it
> (#undef + #define).
absolutely
> So, as people like quick'n'dirty hacks, just make sure that
> TIOCM_MODEM_BITS is also defined in ARM, SH, PPC and Alpha (at least),
> just to make sure I'm the only one complaining.
They are in my tree.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:23 EST