Re: Linux 2.4.20-pre6: compile fixes

From: Eyal Lebedinsky (eyal@eyal.emu.id.au)
Date: Tue Sep 10 2002 - 18:03:19 EST


drivers/net/irda/irtty.c
========================
irtty.c: In function `irtty_set_dtr_rts':
irtty.c:761: `TIOCM_MODEM_BITS' undeclared (first use in this function)

A quick check shows that TIOCM_MODEM_BITS is defined only in
        ./include/asm-parisc/termios.h
as
        #define TIOCM_MODEM_BITS (TIOCM_OUT2 | TIOCM_OUT1)
Now, TIOCM_OUT1/2 are defined for all archs, with identical values,
in the low level asm-*/termios.h. One wonders why it is repeated
in this way.

I am not sure how people want to fix this - I just added a #define
to irtty.c as a quick compile fix.

drivers/net/pcmcia/wavelan_cs.c
===============================
Still does not compile, same as in -pre5 (include issue).

drivers/usb/brlvger.c
=====================
Still does not compile, same as in -pre5 (old gcc issue).

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

--- linux/drivers/net/irda/irtty.c.orig Wed Sep 11 08:33:21 2002 +++ linux/drivers/net/irda/irtty.c Wed Sep 11 08:33:59 2002 @@ -758,6 +758,7 @@ struct irtty_cb *self; struct tty_struct *tty; mm_segment_t fs; +#define TIOCM_MODEM_BITS (TIOCM_OUT2 | TIOCM_OUT1) int arg = TIOCM_MODEM_BITS; self = (struct irtty_cb *) dev->priv;

--- linux/drivers/net/pcmcia/wavelan_cs.c.orig Thu Aug 29 10:10:15 2002 +++ linux/drivers/net/pcmcia/wavelan_cs.c Thu Aug 29 10:21:39 2002 @@ -63,9 +63,9 @@ * */ +#include "wavelan_cs.h" /* Private header */ #include <linux/ethtool.h> #include <asm/uaccess.h> -#include "wavelan_cs.h" /* Private header */ /************************* MISC SUBROUTINES **************************/ /*

--- linux/drivers/usb/brlvger.c.orig Thu Aug 29 10:30:50 2002 +++ linux/drivers/usb/brlvger.c Thu Aug 29 10:31:02 2002 @@ -209,7 +209,7 @@ ({ printk(KERN_ERR "Voyager: " args); \ printk("\n"); }) #define dbgprint(fmt, args...) \ - ({ printk(KERN_DEBUG "Voyager: %s: " fmt, __FUNCTION__, ##args); \ + ({ printk(KERN_DEBUG "Voyager: %s: " fmt, __FUNCTION__ , ##args); \ printk("\n"); }) #define dbg(args...) \ ({ if(debug >= 1) dbgprint(args); })

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:23 EST