Re: [PATCH] 2.5.34 ufs/super.c

From: Skip Ford (skip.ford@verizon.net)
Date: Tue Sep 10 2002 - 12:46:11 EST

Next message: Skip Ford: "Re: [TRIVIAL] Comment fix asm-i386_hardirq.h"
Previous message: Ben Rafanello: "Re: [RFC] Multi-path IO in 2.5/2.6 ? [OFF TOPIC]"
In reply to: Zwane Mwaikambo: "Re: [PATCH] 2.5.34 ufs/super.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Zwane Mwaikambo wrote:
> On Mon, 9 Sep 2002, Skip Ford wrote:
>
> > I've needed this patch since 2.5.32 to successfully mount a UFS
> > partition.
> >
> > --- linux/fs/ufs/super.c~ Mon Sep 9 16:39:52 2002
> > +++ linux/fs/ufs/super.c Mon Sep 9 16:39:57 2002
> > @@ -605,7 +605,7 @@
> > }
> >
> > again:
> > - if (sb_set_blocksize(sb, block_size)) {
> > + if (!sb_set_blocksize(sb, block_size)) {
> > printk(KERN_ERR "UFS: failed to set blocksize\n");
> > goto failed;
> > }
>
> Good heavens! I introduced that bug when fixing another bug a while ago, i
> was pretty certain it got fixed (it got fixed in 2.4 and -dj(?))

Here's the snippet from patch-2.5.32 that did it. This just went in a
week or two ago.

- sb_set_blocksize(sb, block_size);
+ if (sb_set_blocksize(sb, block_size)) {
+ printk(KERN_ERR "UFS: failed to set blocksize\n");
+ goto failed;
+ }

-- 
Skip
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Skip Ford: "Re: [TRIVIAL] Comment fix asm-i386_hardirq.h"
Previous message: Ben Rafanello: "Re: [RFC] Multi-path IO in 2.5/2.6 ? [OFF TOPIC]"
In reply to: Zwane Mwaikambo: "Re: [PATCH] 2.5.34 ufs/super.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:21 EST