Re: [PATCH] 2.5.32-bug

From: Russell King (rmk@arm.linux.org.uk)
Date: Sat Aug 31 2002 - 12:14:38 EST

Next message: Pedro M. Rodrigues: "Re: PROBLEM: nfs & "Warning - running *really* short on DMA buffers""
Previous message: Luca Barbieri: "[PATCH] Fix panic if pnpbios is enabled and speed up its check in do_trap"
In reply to: Ingo Oeser: "Re: [PATCH] 2.5.32-bug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Aug 31, 2002 at 02:00:08PM +0200, Ingo Oeser wrote:
> Hi Rusty,

Grr.

> On Fri, Aug 30, 2002 at 10:39:12PM +0100, Russell King wrote:
> > This patch appears not to be in 2.5.32, but applies cleanly.
> >
> > This patch moves BUG() and PAGE_BUG() from asm/page.h into asm/bug.h.
> >
> > We also fix up linux/dcache.h, which included asm/page.h for the sole
> > purpose of getting the BUG() definition.
> >
> > Since linux/kernel.h makes use of BUG(), asm/bug.h is included there
> > as well.
> > --- orig/include/asm-cris/bug.h Thu Jan 1 01:00:00 1970
> > +++ linux/include/asm-cris/bug.h Sun Jan 6 11:46:09 2002
> > @@ -0,0 +1,12 @@
> > +#ifndef _CRIS_BUG_H
> > +#define _CRIS_BUG_H
> > +
> > +#define BUG() do { \
> > + printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
> > +} while (0)
> > +
> > +#define PAGE_BUG(page) do { \
> > + BUG(); \
> > +} while (0)
> > +
> > +#endif
>
> These kind of implementation of BUG() is not very useful. Callers
> of BUG() and BUG_ON() assume, that the thread is aborted and do
> nothing to fixup after BUG().

Nevertheless, its not up to me to change the implementation that an
architecture has chosen. That's for the individual port maintainers
to fix.

This patch only cleans up the include for the bug stuff so its in a
less silly place. There are _zero_ functional code changes.

-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Pedro M. Rodrigues: "Re: PROBLEM: nfs & "Warning - running *really* short on DMA buffers""
Previous message: Luca Barbieri: "[PATCH] Fix panic if pnpbios is enabled and speed up its check in do_trap"
In reply to: Ingo Oeser: "Re: [PATCH] 2.5.32-bug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:33 EST