[patch 2.5.31] transparent PCI-to-PCI bridges

• Next message: Ben Greear: "Re: packet re-ordering on SMP machines."
• Previous message: Manfred Spraul: "Re: [Fwd: [PATCH] reduce size of bridge regions for yenta.c]"
• Next in thread: Ivan Kokshaysky: "Re: [patch 2.5.31] transparent PCI-to-PCI bridges"
• Reply: Ivan Kokshaysky: "Re: [patch 2.5.31] transparent PCI-to-PCI bridges"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Ivan wrote:
> + /*
> + * The PCI-to-PCI bridge spec requires that subtractive decoding
> + * (i.e. transparent) bridge must have programming interface code
> + * of 0x01.
> + */
> + if (dev->class & 1) {
> + printk("Transparent bridge - %s\n", dev->name);

Why not
        if ((dev->class & 0xff) == 0x01)

Is the lowest bit an indicator of subtractive decoding, or is
Progif==0x01 the indicator of subtractive decoding?
The code and the comment should match.

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Ben Greear: "Re: packet re-ordering on SMP machines."
• Previous message: Manfred Spraul: "Re: [Fwd: [PATCH] reduce size of bridge regions for yenta.c]"
• Next in thread: Ivan Kokshaysky: "Re: [patch 2.5.31] transparent PCI-to-PCI bridges"
• Reply: Ivan Kokshaysky: "Re: [patch 2.5.31] transparent PCI-to-PCI bridges"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:15 EST