RE: [patch] PCI Cleanup

From: Grover, Andrew (andrew.grover@intel.com)
Date: Wed Aug 14 2002 - 21:24:49 EST


> From: Matthew Dobson [mailto:colpatch@us.ibm.com]
> OK... Here's the latest version. Sorry about that last
> posting... Stupid line
> wrapping broke the patch! :( This patch also removes the
> pci_config_(read|write) function pointers. People shouldn't
> be using these (I
> don't think) and should be using the pci_ops structure linked
> through the
> pci_dev structure. These end up calling the same functions that the
> pci_config_(read|write) pointers refer to anyway. The only
> places I can see
> that these are being used in the kernel are in
> drivers/acpi/osl.c... Anyone
> care to comment on the use there or if it can be changed?
> I've cc'd the
> authors of the file...

Hi Matthew,

ACPI needs access to PCI config space, and it doesn't have a struct pci_dev
to pass to access functions. It doesn't look like your patch exposes an
interface that 1) doesn't require a pci_dev and 2) abstracts the PCI config
access method, does it?

Regards -- Andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:38 EST