Re: [patch 1 of 2] Scalable statistics counters

From: Dipankar Sarma (dipankar@in.ibm.com)
Date: Tue Aug 13 2002 - 00:37:25 EST


On Mon, Aug 12, 2002 at 09:09:52PM +0100, Christoph Hellwig wrote:
> On Tue, Aug 13, 2002 at 01:35:46AM +0530, Dipankar Sarma wrote:
> > Suppose I use seq_file interface and not put all statctrs in one /proc
> > file, how do I associate the statctr data structure with the /proc
> > inode ? IOW, how do I quickly get the statctr_pentry corresponding to the
> > counter in statctr_open() ?
>
> Stuff it into the ->private member of struct seq_file in your open method.

Yes, that I learnt by looking at mounts_open(), the problem is how
do I get the statctr_pentry (or statctr_group if you like) in
the open method ? It seems to me that in order to do this, we
need the following -

1. An exported wrapper create_statctr_entry() around
   create_seq_entry() code that sticks the statctr_group pointer into
   proc_entry->data.
2. Some way to get the proc entry from the inode in statctr_open()
   and stick it to seq_file->private for seq_file methods to use.

Is this understanding correct or is there a better and simpler
way to do this ?

Thanks

-- 
Dipankar Sarma  <dipankar@in.ibm.com> http://lse.sourceforge.net
Linux Technology Center, IBM Software Lab, Bangalore, India.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:30 EST