Re: [PATCH] [2.4.20-pre2] File lease fixes

From: Marcelo Tosatti (marcelo@conectiva.com.br)
Date: Mon Aug 12 2002 - 21:47:03 EST


On Tue, 13 Aug 2002, Stephen Rothwell wrote:

> Hi Marcelo,
>
> Here it is again against pre2. Do you have something against this
> patch or do I just slip between the boards?
>
> There are several current problems with the file leases code in 2.4
> including at least one race condition. This is a back port of the
> 2.5 file lease code which solves all the reported problems. It also
> includes a fix for an SMP race condition from Matthew Wilcox.
>
> Thanks to Michael Kerrisk for pushing and testing.

> static inline int get_lease(struct inode *inode, unsigned int mode)
> {
> - if (inode->i_flock && (inode->i_flock->fl_flags & FL_LEASE))
> + if (inode->i_flock)
> return __get_lease(inode, mode);
> return 0;
> }

Why do you remove the FL_LEASE check here?

I see no point doing that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:30 EST