Re: [PATCH] Linux-2.5 fix/improve get_pid()

From: Andries Brouwer (aebr@win.tue.nl)
Date: Fri Aug 09 2002 - 15:40:11 EST


On Fri, Aug 09, 2002 at 02:34:17PM -0500, Paul Larson wrote:

> I suspect that it would actually require more than just this. I tried
> this with the same test I've been using and had several failed attepmts
> at low numbers by getting wierd unexpected signals (like 28), and then
> one that ran for a much longer time and produced an oops with random
> garbage to the console (trying to extract this now).

Not much more. Around 2.3.40 I have run with a large PID_MAX for a long time.
The patch that I submitted is still visible on the net various places
(I just tried Andries pid_max and found a few).

At that time the only other change (other than <linux/threads.h> and
kernel/fork.c) was in proc/base.c, namely

        -#define fake_ino(pid,ino) (((pid)<<16)|(ino))
        +#define fake_ino(pid,ino) (((1)<<16)|(ino))

and

        - if (!pid)
        - goto out;
        - if (pid & 0xffff0000)
        + if (pid <= 0 || pid >= PID_MAX)
                  goto out;

(plucked from google output).

I have not checked precisely what change is appropriate in procfs today.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:20 EST