Re: [PATCH] conditionally re-enable per-disk stats, convert to seq_file

From: Randy.Dunlap (
Date: Wed Aug 07 2002 - 18:10:48 EST

On Wed, 7 Aug 2002, Andries Brouwer wrote:

| > On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote:
| > > This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file
| > > interface as in 2.5, makes it report the sard-style extended disk
| > > statistics condititional on CONFIG_BLK_STATS and disables the gathering
| > > of those totally otherwise to not waste memory and processing power.
| But why in /proc/partitions ?
| Maybe /proc/partitions can go away eventually with all info available
| under driverfs or so. But for the time being, /proc/partitions is used,
| and some changes are planned to make identification of the devices
| involved easier.
| It is really ugly to stuff a lot of garbage into a file just because
| it happens to exist already. If you want disk statistics, why not
| put it in /proc/diskstatistics?

me too.

I'd like to see the disk stats added, but not in /proc/partitions.


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to More majordomo info at Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:38 EST