Re: "new style" netdevice allocation patch for TUN driver (2.4.18 kernel)

From: David S. Miller (davem@redhat.com)
Date: Tue Aug 06 2002 - 12:07:49 EST


   From: "Maksim (Max) Krasnyanskiy" <maxk@qualcomm.com>
   Date: Tue, 06 Aug 2002 10:07:49 -0700
   
   Dave, how about this
   
   --- net/core/dev.c.orig Mon Aug 5 21:48:54 2002
   +++ net/core/dev.c Mon Aug 5 21:54:01 2002
   @@ -2577,6 +2577,11 @@

First, the call-chain notifiers are probably not safe
to run without rtnl_lock held.

Second, why not just fix the bug instead of applying band-aids
to device unregistry? I know it's nice in that it allows you
to configure devices some more, but it doesn't make the real
problem go away.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:32 EST