Re: [PATCH] 2.5.30 Maestro3

From: Alan Cox (
Date: Mon Aug 05 2002 - 10:25:55 EST

On Mon, 2002-08-05 at 14:52, Marcin Dalecki wrote:
> The attached patch is updating the Maestro3 OSS sound chip driver to
> 1. The changes in IRQ handline.
> 2. C99 standard conformant initializers.
> Plese apply. (I happen to use such a chip...)

How about fixing it first ?

> /* must be a better way.. */
> - save_flags(flags);
> - cli();
> + local_irq_save(flags);

This is insufficient. It has to lock against card interrupts and other
arbitary ill defined (in 2.4 anyway) suspend things. Assuming the PM
layer can mind its own business nowdays you are at least going to want
to take the card lock. I think thats mostly sufficient for the maestro
case. There is a long standing question about whether the resume code
should end by calling the irq handler to fake any missed IRQ pending
over the suspend of the card - but thats also true in the 2.4 case.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:27 EST