Re: [PATCH] automatic module_init ordering

From: Sam Ravnborg (
Date: Sun Aug 04 2002 - 15:04:17 EST

On Sun, Aug 04, 2002 at 05:30:47PM +0200, Roman Zippel wrote:
> Could you try the attached patch? It should fix all the mentioned
> problems. Files are now regenerated only if something really changed.
> if_changed needed a fix to correctly save the command line and
> dependencies should be correct now.

Looks good, a few comments remains. We are down to matter of personal taste.

> +builtin_mods := $(addsuffix .builtin_mods,$(sort $(dir $(CORE_FILES) $(LIBS)
A verbose comment above this line descibing the whole concept about initcalls
would be nice. Keep it short and informative.

> + @echo 'cmd_$(@F) := $(cmd_gen_initcalls)' > .$(@F).cmd
I would like to see $(notdir and the counterpart $(dir used instead of
$(@F) and $(@D). The latter two are deprecated by make.
This is general for all of kbuild, but since this is new stuff I bring it up.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:25 EST