On 2 Aug 2002, Alan Cox wrote:
>
> The PnPBIOS gdt setup changes I did are wrong somewhere.
Alan, in your PnP patches you seem to have changed the
"set_limit()"
to a
"_set_limit()"
which looks wrong (or at least doesn't look consistent with the notion of
just doing the same code as before, except on all CPU's).
It _looks_ to me like the QX_SET_SET() macros should be have the "_"
removed from the set_limit part. As it is, _set_limit() gets the address
calculations wrong (because you don't cast it to "char *") and also gets
the limit wrong (because you no longer do the page size adjustment).
Does it work with that small change? I have no idea about the pnpbios
code, I'm just looking at Alan's diff.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:20 EST