Compile warning in fs/partitions/check.c

From: Thunder from the hill (thunder@ngforever.de)
Date: Fri Jul 12 2002 - 17:46:35 EST

Hi,

Compiling fs/partitions/check.c, I get a couple of warnings of "pointer to
integer of different size":

kdev is a kdev_t here, driverfs_dev is a struct device.

        kdev.value=(int)driverfs_dev->driver_data;

Is it okay to replace this with

        kdev.value=(unsigned short)driverfs_dev->driver_data;

to make the warnings go away?

Also, struct driver_file_entry->show gets initialized here:

        show: partition_device_kdev_read,

show being (ssize_t *)(struct device *driverfs_dev, char *page, size_t
                       count, loff_t off);
but expecting (ssize_t *)(void *, char *page, size_t count, loff_t off);

Is it okay to ignore this one?

                                                        Regards,
                                                        Thunder 

-- 
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:24 EST