Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8

From: Andreas Dilger (adilger@clusterfs.com)
Date: Thu Jul 11 2002 - 18:32:26 EST


On Jul 11, 2002 17:14 -0600, Thunder from the hill wrote:
> --- fs/hpfs/dir.c 19 Jun 2002 02:11:50 -0000 1.1.1.1
> +++ fs/hpfs/dir.c 11 Jul 2002 22:12:53 -0000
> @@ -211,7 +211,9 @@ struct dentry *hpfs_lookup(struct inode
>
> lock_kernel();
> if ((err = hpfs_chk_name((char *)name, &len))) {
> - if (err == -ENAMETOOLONG) return ERR_PTR(-ENAMETOOLONG);
> + if (err == -ENAMETOOLONG) {
> + return ERR_PTR(-ENAMETOOLONG);
> + }
> goto end_add;
> }

So, how does adding braces and a linefeed fix the locking problem here?
;-)

Cheers, Andreas

--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 15 2002 - 22:00:21 EST