Re: [PATCH/RFC 2.4.19-rc1] Fix dependancies on keybdev.o

From: Tom Rini (
Date: Wed Jun 26 2002 - 16:23:07 EST

On Thu, Jun 27, 2002 at 06:58:04AM +1000, Brad Hards wrote:
> On Thu, 27 Jun 2002 00:46, Tom Rini wrote:
> > On Wed, Jun 26, 2002 at 12:36:24PM +1000, Brad Hards wrote:
> > > 2. Move keyboard handling code to input subsystem
> >
> > I think that will work out the best. How's the attached look? It moves
> > drivers/input/ inside of drivers/char/ and then fixes
> > arches which had both. (Lightly tested from xconfig[1] for all arches
> > which got changed).
> I'm opposed to further junk going into drivers/char. It is already an
> incomprehensible mess of unrelated code.

drivers/char/ isn't too bad right now. If you skip over the
horrific mess that is serial support, anyhow. Perhaps moving some of
the arch-specific questions out to arch/$(ARCH)/

> Actually, I've got another idea, based on some stuff that I've been working on
> for the ACPI "its not just power management" issue.
> If you need to set something in drivers/input (per your original patch) that
> depends on things that are set in drivers/char (or drivers/usb, anything that
> comes later), then split the into two sections. One section
> contains the normal user-selectable options, and a second
> drivers/input/, that is sourced in at the end of
> arch/foo/ and contains only automated dependancies (ie
> define_bool) but no user selectable options.
> Does this make sense? If not, I'll try for a patch that shows it later this
> morning.

I don't think this makes sense for input however, unless we kill off
drivers/input/ (and for sh/m68k/sparc64 just paste the lines
in) and merge it into drivers/char/ (CONFIG_INPUT,
CONFIG_INPUT_{KEYB,MOUSE,EV}DEV) and drivers/char/joystick/
(CONFIG_INPUT_JOYSTICK). I wouldn't be opposed to doing that...
And for USB (CONFIG_INPUT'ed) joysticks we aren't any worse off, and
perhaps we could even move those into a USB menu.

Tom Rini (TR1265)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:11 EST