Zwane,
I agree, although eventually I envision the code to look like...
if(pci_set_dma_mask(pdev, 0xffffffff))
{
printk(KERN_WARNING "defxx : No suitable DMA available\n");
// Add appropriate action, such as
// goto err_dma_exit;
// OR
return -ENOMEM;
}
Thats why I have the braces (multiple statements).
Regards,
Frank
> Zwane Mwaikambo wrote:
>
>> On Sun, 23 Jun 2002, Frank Davis wrote:
>>
>>
>>> -
>>> + if(pci_set_dma_mask(pdev, 0xffffffff))
>>> + {
>>> + printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>> + }
>>
>>
>>
>> Minor nit,
>> CodingStyle prefers this style;
>>
>> if (pci_set_dma_mask(pdev, 0xffffffff))
>> printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>
>> Thanks,
>> Zwane Mwaikambo
>>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:07 EST