Re: [PATCH] 2.5.21 Nonlinear CPU support

From: Rusty Russell (
Date: Tue Jun 11 2002 - 04:09:44 EST

In message <> you write:
> and slowdown:

ARGH! STOP IT! I realize it's 'leet to be continually worrying about
possible microoptimizations, but I challenge you to *measure* the
slowdown between:

> > - for (i = 0; i < smp_num_cpus; i++) {
> > - int logical = cpu_logical_map(i);


> > + for (i = 0; i < NR_CPUS; i++) {
> > + if (!cpu_online(i))
> > + continue;

*Especially* in this context. Sure, a new "max_cpu_number" or
"cpu_for_each(i)" macro would fix this, but at the expense of using up
additional stack in the reader's brain.

Let's not perpetuate the myth that everything in the kernel needs to
be tuned to the last cycle at all costs, hm?

Yes, you stepped on a sore point 8)
PS. Of course, you know the correct answer, anyway.

  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:21 EST