Re: [PATCH] 2.5.21 - list.h cleanup

From: Martin Dalecki (
Date: Tue Jun 11 2002 - 03:48:11 EST

Użytkownik Linus Torvalds napisał:
> On Tue, 11 Jun 2002, Rusty Russell wrote:
>>Worst sin is that you can't predeclare typedefs. For many uses (not the
>>list macros of course):
>> struct xx;
>>is sufficient and avoids the #include hell,
> True.
> However, that only works for function declarations.
> typedefs are easy to avoid.
> The real #include hell comes, to a large degree, from the fact that we
> like inline functions. Which have many wonderful properties, but they have
> the same nasty property typedefs have: they require full type information
> and cannot be predeclared.
> And while I'd like to avoid #include hell, I'm not willing to replace
> inline functions with #define's to avoid it ;^p

That's true, but please note that there is quite a lot
of inadequate include abuse in Linux. People are just too
lazy to check whatever inlining something really speeds things
up. For example the functions used to copy data between
userspace and kernel are very likely to be executed not much slower
if *not* included. In fact they should not turn up
on *any* benchmark - becouse if they do we have other problems...
Namely we have a system call which is basically doing nothing.
But they show up significantly on the .text size.

And then we have quite a lot if silly include code like the following:

static inline function()

Which doesn't really make much sense, quite frequently, becouse
We will trash caches anyway...


static inline int iterator()

This doesn't make sense too, becouse
the CPUs tends to be good at branch prediction and if
a function is mainly used inside loops again and again
it doesn't make sense to make them inline frequently too.

And so on and so on...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 15 2002 - 22:00:21 EST