[PATCH] matroxfb dies when you try to use secondary head in 2.5.x

• Next message: Tomas Vanderka: "Re: gettimeofday clock jump bug"
• Previous message: William Lee Irwin III: "Re: remove magic numbers for fault return codes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Linus,
   please apply this to 2.5.20. James introduced bad bug which
causes NULL pointer dereference as soon as you'll try to use
secondary head because of screen_base is not initialized
(it is initialized on wrong head).
                                Thanks,
                                        Petr Vandrovec
                                        vandrove@vc.cvut.cz

diff -urdN linux/drivers/video/matrox/matroxfb_crtc2.c linux/drivers/video/matrox/matroxfb_crtc2.c
--- linux/drivers/video/matrox/matroxfb_crtc2.c Mon Jun 3 01:44:45 2002
+++ linux/drivers/video/matrox/matroxfb_crtc2.c Fri Jun 7 23:03:07 2002
@@ -383,7 +383,7 @@
                 chgvar = 0;
         p->var = *var;
         /* cmap */
- ACCESS_FBINFO(fbcon.screen_base) = vaddr_va(m2info->video.vbase);
+ m2info->fbcon.screen_base = vaddr_va(m2info->video.vbase);
         p->visual = visual;
         p->ypanstep = 1;
         p->ywrapstep = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Tomas Vanderka: "Re: gettimeofday clock jump bug"
• Previous message: William Lee Irwin III: "Re: remove magic numbers for fault return codes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:31 EST