Re: [PATCH] page coloring for 2.4.18 kernel

From: David S. Miller (davem@redhat.com)
Date: Tue Jun 04 2002 - 08:16:40 EST


   From: Jason Papadopoulos <jasonp@boo.net>
   Date: Sun, 07 Apr 2002 11:01:00 -0400

   Hello. This is a re-diff of the 2.4.17 patch I posted
   previously.
   
   www.boo.net/~jasonp/page_color-2.2.20-20020108.patch
   www.boo.net/~jasonp/page_color-2.4.17-20020113.patch
   www.boo.net/~jasonp/page_color-2.4.18-20020323.patch
   
   I'm not subscribed to LKML, so please cc responses
   to this email address.

Hi Jason. I noticed that your code assumes zones begin on well
aligned physical addresses. This is not true.

For example, in page_color_start you use the raw
(page - zone->zone_mem_map) index as the color. This
is wrong, what if the zone starts at page 1? In such
a case all of your colors will be computed incorrectly
and pages with different colors in different zones can actually be of
the same color.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:20 EST