Re: [PATCH] 2.4.19-pre10 s/Efoo/-Efoo/ drivers/char/rio/*.c

From: Rasmus Andersen (rasmus@jaquet.dk)
Date: Tue Jun 04 2002 - 04:00:32 EST


On Tue, Jun 04, 2002 at 04:48:58PM +0800, Anthony J. Breeds-Taurima wrote:
> Hello All,
> This is another cleanup patch changing positive return values into
> negative's.
>
>
> Yours Tony
>
> Jan 22-26 2003 Linux.Conf.AU http://conf.linux.org.au/
> The Australian Linux Technical Conference!
>
> --------------------------------------------------------------------------------
> diff -X dontdiff -urN linux-2.4.19-pre10.clean/drivers/char/rio/rio_linux.c linux-2.4.19-pre10/drivers/char/rio/rio_linux.c
> --- linux-2.4.19-pre10.clean/drivers/char/rio/rio_linux.c Tue Apr 30 13:22:07 2002
> +++ linux-2.4.19-pre10/drivers/char/rio/rio_linux.c Tue Jun 4 16:27:36 2002
> @@ -702,7 +702,7 @@
> func_enter();
>
> /* The "dev" argument isn't used. */
> - rc = -riocontrol (p, 0, cmd, (void *)arg, suser ());
> + rc = riocontrol (p, 0, cmd, (void *)arg, suser ());

I'm sorry but since this code indeed changes the positive return
codes into negatives, what is the purpose of your patch? Have you
talked to the maintainer (R.E.Wolff)?

Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jun 07 2002 - 22:00:19 EST