Re: [PATCH] SLC82C105 IDE driver: missing __init

From: Andrey Panin (pazke@orbita1.ru)
Date: Wed May 22 2002 - 09:09:38 EST

Next message: bert hubert: "Re: Have the 2.4 kernel memory management problems on large machines been fixed?"
Previous message: M. Edward Borasky: "Have the 2.4 kernel memory management problems on large machines been fixed?"
In reply to: Alan Cox: "Re: [PATCH] SLC82C105 IDE driver: missing __init"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, May 22, 2002 at 02:10:06PM +0100, Alan Cox wrote:
> > slc82c105_bridge_revision() functions lacks __init modifier.
> > Attached patch (against 2.5.17) fixes it.
> > Compiles, but untested. Please consider applying.
>
> I wouldnt get too carried away with these. Once the IDE core is clean
> enough to allow hot plugging of IDE interfaces those __init's are all going
> to need changing anyway

Then we'll grep and change them to __devinit.
But missing __init can't be changed :))

> (and yes you can get hot pluggable IDE setups already - the mobility stuff
> for example has a case with a PCI split bridge, 3 or 4 PCI slots and
> connects to the cardbus on a laptop)

-- 
Andrey Panin            | Embedded systems software engineer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net

application/pgp-signature attachment: stored

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: bert hubert: "Re: Have the 2.4 kernel memory management problems on large machines been fixed?"
Previous message: M. Edward Borasky: "Have the 2.4 kernel memory management problems on large machines been fixed?"
In reply to: Alan Cox: "Re: [PATCH] SLC82C105 IDE driver: missing __init"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 23 2002 - 22:00:25 EST