I was looking at this with Jack Vogel and I can't figure out how it goes
wrong, either. However, the code in move() that uses the cpu number is a bit
strange. Entering loops in their middles is generally considered bug-prone
by programming style books. What about eliminating the goto by using
something like the attached patch?
On Tuesday 21 May 2002 02:52 pm, Greg KH wrote:
> I can't seem to run a SMP 2.5.17 kernel on a UP machine, it locks up
> during the boot process. In talking to Jack Vogel, he suggested I make
> the following patch, which seems to solve the problem for me. In
> looking at the code, I have no idea of why this seems to work, so there
> probably is a better fix out there.
>
> Any suggestions?
>
> thanks,
>
> greg k-h
>
>
>
> diff -Nru a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
> --- a/arch/i386/kernel/io_apic.c Tue May 21 14:47:06 2002
> +++ b/arch/i386/kernel/io_apic.c Tue May 21 14:47:06 2002
> @@ -205,7 +205,7 @@
> } ____cacheline_aligned irq_balance_t;
>
> static irq_balance_t irq_balance[NR_IRQS] __cacheline_aligned
> - = { [ 0 ... NR_IRQS-1 ] = { 1, 0 } };
> + = { [ 0 ... NR_IRQS-1 ] = { 0, 0 } };
>
> extern unsigned long irq_affinity [NR_IRQS];
>
> -
--
James Cleverdon
IBM xSeries Linux Solutions
{jamesclv(Unix, preferred), cleverdj(Notes)} at us dot ibm dot com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 23 2002 - 22:00:24 EST