> > I guess it still is "$_ =~ s/\[?PATCH\]?\s*//i;", which means
> > that it still is broken. There certainly are several solutions,
> > what do people think of "s/\[?[^\]]*PATCH\]?\W*//i;" ?
> > (Maybe a ^ at the beginning?)
>
> Don't guess, look:
>
> # kill "PATCH" tag
> s/^\s*\[PATCH\]//;
> s/^\s*PATCH//;
> s/^\s*[-:]+\s*//;
> # strip trailing colon
> s/:\s*$//;
> # kill leading and trailing whitespace for consistent indentation
> s/^\s+//; s/\s+$//;
>
> So it should not harm "[ARM PATCH]".
>
> What we would want is only remove the tag when we have symmetric square
> brackets. What we also want is simplicity to allow for easy maintenance
> and, last but not least, simple, anchored regexps for speed.
Good.
Could you repost the latest version *in plaintext* please?
T.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu May 23 2002 - 22:00:16 EST