Re: [PATCH] percpu updates

From: Andrew Morton (akpm@zip.com.au)
Date: Wed May 01 2002 - 17:44:33 EST


Brian Gerst wrote:
>
> These patches convert some of the existing arrays based on NR_CPUS to
> use the new per cpu code.
>
> ...
> -extern struct page_state {
> +struct page_state {
> unsigned long nr_dirty;
> unsigned long nr_locked;
> unsigned long nr_pagecache;
> -} ____cacheline_aligned_in_smp page_states[NR_CPUS];
> +};
> +
> +extern struct page_state __per_cpu_data page_states;

When I did this a couple of weeks back it failed in
mysterious ways and I ended up parking it. Failure
symptoms included negative numbers being reported in
/proc/meminfo for "Locked" and "Dirty".

How well has this been tested? (If the answer
is "not very" then please wait until I've tested
it out...)

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 07 2002 - 22:00:11 EST