On Sat, Apr 27, 2002 at 09:45:10AM -0500, Corey Minyard wrote:
> >Any reason for initialising it there instead of using a subsys_initcall
> >from smbios.c ?
> Can you control other orders within the subsystem?
Use different types of _initcall. See include/linux/init.h
> Other things that come later in this subsystem might need it
> Actually, it might be needed before this, I've moved it to before the PCI
> initialization,
> since this contains interrupt information and possible PCI information.
Ok, I overlooked the relationship of PCI to SMBIOS.
As pci is initialised with subsys_initcall, you could initialise
earlier by using core_initcall.
> > > + char str[80];
> >Worth adding a if (len>80) return here in case of crap biosen?
> >Or am I overly paranoid?
> It's printing 16 hex characters every time, so it doesn't matter. And
> it's only debug code, anyway.
Ok.
Dave.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Apr 30 2002 - 22:00:14 EST