On Fri, Apr 26, 2002 at 10:00:50PM -0500, Corey Minyard wrote:
Hi Corey,
> --- ./arch/i386/kernel/pci-pc.c.smbios Fri Apr 26 10:59:55 2002
> +++ ./arch/i386/kernel/pci-pc.c Fri Apr 26 11:00:13 2002
> @@ -1293,6 +1293,10 @@
> return;
> }
>
> +#ifdef CONFIG_SMBIOS
> +extern void smbios_init(void);
> +#endif
> +
> void __init pcibios_init(void)
> {
> int quad;
> @@ -1322,6 +1326,10 @@
>
> pcibios_fixup_irqs();
> pcibios_resource_survey();
> +
> +#ifdef CONFIG_SMBIOS
> + smbios_init();
> +#endif
>
> #ifdef CONFIG_PCI_BIOS
> if ((pci_probe & PCI_BIOS_SORT) && !(pci_probe & PCI_NO_SORT))
Any reason for initialising it there instead of using a subsys_initcall
from smbios.c ?
> +void __init hexdump (u8 *data, int len)
Something this generic sounding should be static.
> + char str[80];
Worth adding a if (len>80) return here in case of crap biosen?
Or am I overly paranoid?
Dave.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Apr 30 2002 - 22:00:13 EST