Re: novice coding in /linux/net/ipv4/util.c From: DJ Barrow <dj.barrow@asitatech.com>

From: Andi Kleen (ak@suse.de)
Date: Mon Apr 22 2002 - 12:07:38 EST


DJ Barrow <dj.barrow@asitatech.com> writes:

> This textbook peice of novice coding which has existed since 2.2.14.

Even earlier I think

BTW do you call libresolv novice coding too ?

> For those who can't spot the error, please note that this function is
> returning a static string, excellent stuff if you are hoping to reuse the
> same function like the following
> printk("%s %s\n",in_ntoa(addr1),in_ntoa(addr2));

That is why most of networking uses the NIPQUAD macro instead.

Best would be probably to convert the few remaining users of in_ntoa
to NIPQUAD and drop this function.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Apr 23 2002 - 22:00:31 EST