Re: HDLC driver for MPC860-based hardware

From: Francois Romieu (romieu@cogenit.fr)
Date: Mon Apr 22 2002 - 06:34:14 EST

Next message: Thomas Zeitlhofer: "nbd + raid1 + 2.4.19-pre7"
Previous message: Libor Vanėk: "Adding snapshot capability to Linux"
In reply to: Adam Kaczynski: "HDLC driver for MPC860-based hardware"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Greetings,

- please, please, please read Documentation/CodingStyle
- kmalloc can fail
- cache seems to be disabled (?) for pages you memcpy later -> why ?
- if register_hdlc_device() fails for some device, the succeeded one are
deallocated but not unregistered
- alloc_mem() doesn't deallocate on failure
- goto may help handling failure

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Thomas Zeitlhofer: "nbd + raid1 + 2.4.19-pre7"
Previous message: Libor Vanėk: "Adding snapshot capability to Linux"
In reply to: Adam Kaczynski: "HDLC driver for MPC860-based hardware"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Apr 23 2002 - 22:00:30 EST